I think it's not sufficient to use --gzip instead of --bzip2 (well: for the backup itself this is sufficient but this is not all) - I'd also change the filename (.tar.bz2 -> .tar.gz or .tgz), and therefore maybe also the website dealing with backups may need some small changes.

/J

Here's my patch... I've to test it...

There is another variable for ispcp.conf (path to gzip) :-(
(but I saw that there still are scripts used without patch - eg. zcat/bzcat)...

And another thing: since the comment about the location/name of the backup is multilanguage - we need to change all language files...

/Joximu

patch to 953...

This post was last modified: 01-06-2008 06:53 AM by joximu.

A bit more i expected XD my fault. XD

Ok, I just let it run and also did a restore.
For me it seems to be ok - except the missing translations...

"(usually named backup_YYYY_MM_DD.tar.gz)"

Maybe someone else could do some testing - then I'll commit this...

/J

A remark to my patch:

without the part of config/ispcp you can use it on a installed system...
and then put the gzip-patch variable manually in the ispcp.conf...

/J

In r956 you can choose which zip Algo you want to use. You only have to set ZIP in ispcp.config to your favorite.

The Patch is untested and maybe has to fixed. Please test, I've not time to do it!

Great
RatS's doing a one-man-show, no caring about anyone else...

Not as much as you believe. There are requests, there are patches of you that do not convinced me and there is no time for discussing. If you don't like the way I've done, please criticise it but do not criticize me!

Back on topic guys, I see that RatS added the option to specify which backup compression to use. Isn't this a good thing since choice is always KING!

Jox, what are your objections to RatS's changes (if any)?

Hi
well, it's not the change from RatS, it's rather the fact that we tried to do the change so that RatS can spend his rare time ("I've not time to do it!") on a more important ticket (update script) - now Zothos made a patch (a start), I did (well, without choice but it was tested!) and RatS also did - well after the third commit - it runs hopefully.
So, sorry for my personal attack - I'm just concerned about howto finally get the next step with ispcp. I totally understand RatS, he made the promise with the update script, he feels very responsible for the whole project and sometimes it seems that he thinks he has to do everything by himself.
IMHO the project management is sort of not there. And "there are patches of you that do not convinced me" is not very helpful and "there is no time for discussing" is bullshit.
I'm really not the person who always wants to talk/discuss and I'm known as being an optimistic person - well, I'm loosing the optimism here...

/Joximu

Edit: I hope you get my point...

This post was last modified: 01-07-2008 05:58 AM by joximu.