Development

Wiki Start
Wishlist
Timeline
Roadmap
Browse Source
New Ticket
View Tickets

Ticket #1132 (closed defect: fixed)

Opened 6 months ago

Last modified 5 months ago

Hardcoded theme image paths

Reported by: Eminos Assigned to:
Priority: minor Milestone: ispCP ω 1.0.0 - RC5
Component: Frontend (GUI) Version: ispCP ω 1.0.0 - RC4
Severity: Don't know Keywords:
Cc:

Description

In some client tpl-files (perhaps admin and reseller as well) there are hardcoded URLs like:
url(../themes/omega_original/images/top/top_bg.jpg
instead of:
url{THEME_COLOR_PATH}/images/top/top_bg.jpg

Some pages seems to be OK, like Webtools.

Attachments

Change History

(follow-up: ↓ 2 ) 03/24/08 13:30:08 changed by rats

  • status changed from new to closed.
  • resolution set to fixed.
  • milestone changed from Working to ispCP ω 1.0.0 - RC5.

changed in r1076; even if it won't hurt, because the files belong to the theme (are all in theme folder).

(in reply to: ↑ 1 ) 03/24/08 14:30:02 changed by anonymous

Replying to rats:

changed in r1076; even if it won't hurt, because the files belong to the theme (are all in theme folder).

It does hurt when you make your own themes based on the default one. (which is the point with url variables) Thanks for fix.

(follow-up: ↓ 4 ) 03/24/08 17:58:35 changed by rats

no, it won't: your own theme should not be located at omega_original folder

(in reply to: ↑ 3 ) 03/24/08 18:00:21 changed by rats

Replying to rats:

no, it won't: your own theme should not be located at omega_original folder

to explain a bit further: the "hard coded" parts are in the tpl (template) files not the php (frontend) files. So it won't cause harm

03/24/08 21:37:04 changed by Eminos

What I ment was if you COPY the omega_original folder and start a new theme from there, you will have trouble with the hard coded urls. The meaning with variables is clear, and it is only consistent to have variables all the way and not only on some urls. This was a bug which is now fixed. Case closed.

03/26/08 14:32:21 changed by anonymous

rapidshare search engine

04/07/08 10:10:11 changed by dzsiszgpp

wQFsfW <a href="http://hkbqlxxhemlv.com/">hkbqlxxhemlv</a>, [url=http://gfzavnfchegv.com/]gfzavnfchegv[/url], [link=http://hhbvmbwnayti.com/]hhbvmbwnayti[/link], http://mmizcjwfpjsx.com/

Add/Change #1132 (Hardcoded theme image paths)




Action