Ticket #1172 (closed defect: fixed)

Opened 8 months ago

Last modified 8 months ago

Regenerate proftpd config fails in update

Reported by: anonymous Assigned to:
Priority: critical Milestone: ispCP ω 1.0.0 - RC5
Component: Backend (Engine) Version: ispCP ω 1.0.0 - RC4
Severity: Don't know Keywords:
Cc:

Description

When no config is available in the proftpd/backup dir the updater uses the setup_ftpd() function in ispcp-setup-methods.pl to regenerate the config files. This function tries to use undefined values for DATABASE_USER and DATABASE_PASS, which aborts the process.

Attachments

ispcp-setup-methods.pl.patch (0.9 kB) - added by FeG on 04/07/08 18:35:00.
patch for asking the user for ftp_user and pass if necessary

Change History

04/07/08 18:35:00 changed by FeG

  • attachment ispcp-setup-methods.pl.patch added.

patch for asking the user for ftp_user and pass if necessary

04/07/08 18:36:58 changed by FeG

In ispcp-setup this is done on line 154ff:

# # ispCP ftp SQL user questions; #

$rs = ask_db_ftp_user(); return $rs if ($rs != 0);

do {

$rs = ask_db_ftp_password();

} while ($rs == 1);

ispcp-update doesn't do this, but the values which are used for DATABASE_USER and DATABASE_PASS are set by these two functions (ask_db_ftp_user() and ask_db_ftp_password()).

So I suppose to ask for these values in setup_ftpd() if the needed variables aren't set. I've just added where I've made this change in the ispcp-setup-methods.pl - setup_ftpd() function. Hope this will do the job.

04/09/08 09:52:46 changed by rats

  • milestone changed from Working to ispCP ω 1.0.0 - RC5.

04/13/08 23:43:05 changed by rats

  • status changed from new to closed.
  • resolution set to fixed.

you're right, we can overwrite it without any trouble; noone needs the password ...

changed in r1113


Add/Change #1172 (Regenerate proftpd config fails in update)




Action