Ticket #1174 (closed defect: fixed)

Opened 8 months ago

Last modified 8 months ago

Traffic at midnight not displayed

Reported by: anonymous Assigned to:
Priority: major Milestone: ispCP ω 1.0.0 - RC5
Component: Frontend (GUI) Version: ispCP ω 1.0.0 - RC4
Severity: Don't know Keywords:
Cc:

Description

The domains_statistics script (of admin, reseller and client) has a gap at midnight. Because of the time-settings (23:59:59 and especially 00:00:00) the relational operator should be in all occurrences of the SQL-Query '>=' and '<=' respectivly.

  $query = <<<SQL_QUERY
        select
            IFNULL(sum(dtraff_web), 0) as web_dr,
            IFNULL(sum(dtraff_ftp), 0) as ftp_dr,
            IFNULL(sum(dtraff_mail), 0) as mail_dr,
            IFNULL(sum(dtraff_pop), 0) as pop_dr
        from
            domain_traffic
        where
            domain_id = ? and dtraff_time >= ? and dtraff_time <= ?

Attachments

domain_statistics.php-admin.patch (0.7 kB) - added by FeG on 04/07/08 18:10:53.
Patch for admin/domain_statistics.php
domain_statistics.php-client.patch (0.8 kB) - added by FeG on 04/07/08 18:11:24.
Patch for client/domain_statistics.php
domain_statistics.php-reseller.patch (0.9 kB) - added by FeG on 04/07/08 18:12:56.
Patch for reseller/domain_statistics.php

Change History

04/06/08 21:10:19 changed by zothos

Could you please specify your issue a bit? Im a bit confused what you mean XD

04/07/08 18:10:53 changed by FeG

  • attachment domain_statistics.php-admin.patch added.

Patch for admin/domain_statistics.php

04/07/08 18:11:24 changed by FeG

  • attachment domain_statistics.php-client.patch added.

Patch for client/domain_statistics.php

04/07/08 18:12:56 changed by FeG

  • attachment domain_statistics.php-reseller.patch added.

Patch for reseller/domain_statistics.php

04/07/08 18:14:40 changed by FeG

What he ment was: On creating the domain statistics, the data is collected in the following range:

00:00:00 < Date/Time of entry < 23:59:59

But like this, the two seconds "00:00:00" and "23:59:59" are excluded, so the < and > has to be changed to <= and >=.

I've just supplied these three little patches to change this..

04/07/08 20:02:03 changed by zothos

  • status changed from new to closed.
  • resolution set to fixed.

thx FeG :)

fixed in r1105

04/07/08 22:25:15 changed by rats

  • milestone changed from Working to ispCP ω 1.0.0 - RC5.

Add/Change #1174 (Traffic at midnight not displayed)




Action