Development

Wiki Start
Wishlist
Timeline
Roadmap
Browse Source
New Ticket
View Tickets

Ticket #1220 (closed defect: fixed)

Opened 2 months ago

Last modified 2 months ago

Several problem with new mail configuration

Reported by: Cube Assigned to:
Priority: blocker Milestone: ispCP ω 1.0.0 - RC5
Component: Backend (Engine) Version: ispCP ω 1.0.0 - RC4
Severity: Don't know Keywords: mail
Cc:

Description (Last modified by joximu)

The new possibilities to configure the mail accounts in r1128 are totally buggy. Here are some errors I found, probably there are more.

Clicking in ispCP on a mailbox (domain mail) I would expect to get the possibility to edit the password (like it was in older revisions). But now I can set forwards, it's not possible to set a new password.

When I try to enter an address into the textfield here, the account completely disappears. mail_type in DB: NULL

Clicking on a combined mailbox and forward I can only set a new password, but cannot change the forward.

When I try to delete an adress I get an unknown error. Status in DB: ''get_file() | ERROR: Undefined input data, fname: || !''

For editing it would be the best to show the same form, that is shown for addition, but without the field username. So it would be possible to enable/disable/edit mailbox and forward for each adress, no matter what it was before.

Attachments

edit_mail_acc.php.patch (2.8 kB) - added by JCD on 05/08/2008 03:00:59 PM.
Diff of edit_mail_acc.php
edit_mail_acc.tpl.patch (5.0 kB) - added by JCD on 05/08/2008 03:02:10 PM.
Diff of edit_mail_acc.tpl

Change History

04/29/2008 12:47:23 AM changed by joximu

  • description changed.

(follow-up: ↓ 3 ) 04/29/2008 09:03:59 AM changed by xister

Maybe JCD can help. It´s his work and he´s our german translator :) http://www.isp-control.net/ispcp/ticket/1196

(in reply to: ↑ 2 ; follow-up: ↓ 4 ) 04/29/2008 05:37:13 PM changed by Cube

Replying to xister:

Maybe JCD can help.

I will write him a mail for the case he does not recognize this ticket.

(in reply to: ↑ 3 ) 04/29/2008 06:34:55 PM changed by JCD

This shouldn't happen. I will look into this.

05/06/2008 03:52:54 PM changed by zothos

  • priority changed from critical to blocker.
  • milestone changed from Working to ispCP ω 1.0.0 - RC5.

05/08/2008 02:57:50 PM changed by JCD

This error was caused by the edit_mail_acc.tpl which lacked my patches. The crucial changes I introduced with my patches in ticket #1196 were missing. These two patches take care of that. Moreover I reworked the disable of the forward_list field. Now it also works with broken/disabled JavaScript?. I also fixed the broken "empty password" detection mentioned in my ticket #1132. Here's a summary of that problem:

If you don't enter a password and also no forward, the empty password isn't recognized. This happens because after {{{ $pass = escapeshellcmd($_POSTpass?); }}} $pass somehow has a value of " ". So it isn't recognized by {{{

if ($pass ===

$pass_rep === $mail_id === !is_numeric($mail_id)) { }}} This here seems to do the job: {{{

if (trim($pass) ===

trim($pass_rep) === $mail_id === !is_numeric($mail_id)) { }}}

The two patches are attached.

05/08/2008 03:00:59 PM changed by JCD

  • attachment edit_mail_acc.php.patch added.

Diff of edit_mail_acc.php

05/08/2008 03:02:10 PM changed by JCD

  • attachment edit_mail_acc.tpl.patch added.

Diff of edit_mail_acc.tpl

05/08/2008 06:35:32 PM changed by rats

  • status changed from new to closed.
  • resolution set to fixed.

fixed in r1140

Add/Change #1220 (Several problem with new mail configuration)




Action