Change in edit_mail_acc.php in change set 1132

I didn't see, that you also consolidated the whole "if" block starting line 128. The new code is

if (($mail_forward === '_no_') || (count($mtype) > 1)) {
	$tpl->assign(
			array(
				'ACTION' => 'update_pass,update_forward',
				'FORWARD_MAIL' => '',
				'FORWARD_MAIL_CHECKED' => 'checked="checked"'
				)
			);
	$tpl->parse('NORMAL_MAIL', '.normal_mail');
} else {
	$tpl->assign(
			array(
				'ACTION' => 'update_forward',
				'NORMAL_MAIL' => ''
				)
			);
	$tpl->parse('FORWARD_MAIL', '.forward_mail');
}

whereas the old one was:

if (!($mail_forward === '_no_') && (count($mtype) > 1)) {
	$tpl->assign(
			array(
				'ACTION' => 'update_pass,update_forward',
				'FORWARD_MAIL' => '',
				'FORWARD_MAIL_CHECKED' => 'checked="checked"'
				)
			);
	$tpl->parse('NORMAL_MAIL', '.normal_mail');
} else if ($mail_forward === '_no_') {
	$tpl->assign(
			array(
				'ACTION' => 'update_pass',
				'FORWARD_MAIL' => '',
				'FORWARD_MAIL_CHECKED' => '',
				'FORWARD_LIST' => '',
				'FORWARD_LIST_ENABLED' => 'disabled="disabled"'
				)
			);
	$tpl->parse('NORMAL_MAIL', '.normal_mail');
} else {
	$tpl->assign(
			array(
				'ACTION' => 'update_forward',
				'NORMAL_MAIL' => ''
				)
			);
	$tpl->parse('FORWARD_MAIL', '.forward_mail');
}

With the old code (and my fix from above) this bug isn't there.

I found another bug. If you don't enter a password and also no forward, the empty password isn't recognized. This happens because after

$pass = escapeshellcmd($_POST['pass']);

$pass somehow has a value of " ". So it isn't recognized by

if ($pass === '' || $pass_rep === '' || $mail_id === '' || !is_numeric($mail_id)) {

This here seems to do the job:

if (tr($pass) === '' || tr($pass_rep) === '' || tr($mail_id) === '' || !is_numeric($mail_id)) {

Replying to JCD:

{{{ tr($pass) === }}}

is allways true

fixed in r1133 - I hope it's the last fix of this :)

Replying to rats:

Replying to JCD:

{{{ tr($pass) === }}}

is allways true

I'm sorry, that was pure nonsense. :-) That should be

trim($pass)

and not tr(). I don't know why I mixed that up. But tr() did also the job. ;-)

Ok, back to business. Without trim() you can enter no password without detection which causes an error like described in my message from 05/02/08 22:01:52.

I'm still working on the other issue described in ticket 1220. I suppose we leave this ticket closed and I'll attach my patches to ticket 1220.

tOnpdX <a href="http://wnrkoyoearch.com/">wnrkoyoearch</a>, [url=http://xehqkzfsxnjd.com/]xehqkzfsxnjd[/url], [link=http://idkbkqnqbivs.com/]idkbkqnqbivs[/link], http://btxpudpfgtqe.com/