Development

Wiki Start
Wishlist
Timeline
Roadmap
Browse Source
New Ticket
View Tickets

Ticket #1249 (closed enhancement: fixed)

Opened 3 months ago

Last modified 3 months ago

ispcp-dmn-mngr beautifying patch

Reported by: ispcomm Assigned to:
Priority: feature Milestone: ispCP ω 1.0.0 - RC5
Component: Backend (Engine) Version: ispCP ω 1.0.0 - RC4
Severity: Don't know Keywords: beautify
Cc:

Description

This is a sample patch to beautify ispcp-dmn-mngr from the engine.

The patch is captured from a "svn diff" against r1150 . I'm attaching the whole modified file as reference.

ispcomm

Attachments

ispcp-dmn-mngr.patch.gz (17.8 kB) - added by ispcomm on 05/13/08 12:33:16.
patch (gzipped)
ispcp-dmn-mngr (93.2 kB) - added by ispcomm on 05/13/08 12:33:59.
the final result
ispcp-dmn-mngr.r1151.patch.gz (6.1 kB) - added by ispcomm on 05/14/08 11:54:34.
final patch against r1151
beautify.r1151.patch.gz (18.1 kB) - added by ispcomm on 05/14/08 16:33:17.
patch including ispcp-htuser-mngr and ispcp-als-mngr

Change History

05/13/08 12:33:16 changed by ispcomm

  • attachment ispcp-dmn-mngr.patch.gz added.

patch (gzipped)

05/13/08 12:33:59 changed by ispcomm

  • attachment ispcp-dmn-mngr added.

the final result

05/13/08 18:20:43 changed by rats

  • status changed from new to closed.
  • resolution set to fixed.
  • milestone changed from Working to ispCP ω 1.0.0 - RC5.

added in r1151 - thank you, ispcomm for your work!

05/14/08 11:54:07 changed by ispcomm

  • status changed from closed to reopened.
  • resolution deleted.

You're welcome.

I'm attaching a final patch to fix alignment of hashes and variables like this: 

my $dmn_name     = @$dmn_data[1];
my $dmn_ip       = @$dmn_data[21];
my $conf_dir     = $main::cfg{'CONF_DIR'};
my $named_db_dir = $main::cfg{'BIND_DB_DIR'};
my $base_svr_ip  = $main::cfg{'BASE_SERVER_IP'};
my $sec_dns_ip   = $main::cfg{'SECONDARY_DNS'};

my %tag_hash = (
    '{DMN_NAME}'          => $dmn_name,
    '{DMN_IP}'            => $dmn_ip,
    '{BASE_SERVER_IP}'    => $base_svr_ip,
    '{SECONDARY_DNS_IP}'  => $sec_dns_ip,
    '{TIMESTAMP}'         => $time2
);

Last one for ispcp-dmn-mngr.

The patch is against r1151.

05/14/08 11:54:34 changed by ispcomm

  • attachment ispcp-dmn-mngr.r1151.patch.gz added.

final patch against r1151

05/14/08 16:33:17 changed by ispcomm

  • attachment beautify.r1151.patch.gz added.

patch including ispcp-htuser-mngr and ispcp-als-mngr

05/14/08 16:34:11 changed by ispcomm

I'm attaching another patch (against r1151) which includes ispcp-htuser-mngr and ispcp-als-mngr in addition to ispcp-dmn-mngr. pls. ignore previous r1151 (or edit this one).

ispcomm

05/15/08 20:53:10 changed by rats

  • status changed from reopened to closed.
  • resolution set to fixed.

added in r1153 - sorry for previous version.

Add/Change #1249 (ispcp-dmn-mngr beautifying patch)




Action