Development

Wiki Start
Wishlist
Timeline
Roadmap
Browse Source
New Ticket
View Tickets

Ticket #1256 (closed defect: fixed)

Opened 2 months ago

Last modified 2 months ago

admin's database update does not stop if there is an update failure

Reported by: anonymous Assigned to:
Priority: major Milestone: ispCP ω 1.0.0 - RC5
Component: Frontend (GUI) Version: ispCP ω 1.0.0 - RC4
Severity: Don't know Keywords:
Cc:

Description

Currently the database update (ispcp/gui/include/database-update-functions.php) loops each available update-function and does not stop if there is a error. This rusults in an iteration of the DATABASE_REVISION with each while-loop run. To permit the iteration if there goes something wrong with the update I've added an break into this loop, see the attached patch. There is room for optimization, maybe you could move the $sql->CompleteTrans?() and unset($queryArray) before the if-clause.

Attachments

database-update-functions.php.patch (0.7 kB) - added by anonymous on 05/15/08 15:55:23.
the patch for database-update-functions.php against r1153.

Change History

05/15/08 15:55:23 changed by anonymous

  • attachment database-update-functions.php.patch added.

the patch for database-update-functions.php against r1153.

05/15/08 16:45:00 changed by zothos

  • status changed from new to closed.
  • resolution set to fixed.
  • component changed from Backend (Engine) to Frontend (GUI).
  • milestone changed from Working to ispCP ω 1.0.0 - RC5.

fixed in r1154

Add/Change #1256 (admin's database update does not stop if there is an update failure)




Action