not possible to add a MySQL DB

r1258 but I can`t reproduce

switch from Admin to Customer. The enter MANAGE SQL and try to Add an DB. I'm not the only one with this Error. An other User has the same Error.

Testet with r1258. The same Error.

Here is the Post (german!)

[http://www.isp-control.net/forum/this-command-is-not-supported-t-3664.html]

It seems to be a version related. With debian lenny I cant reproduce(mysql 5.0.51a-6, php 5.2.5). gOOvER can you test following patch? Its only for test to convince myself that I found the problem

It is a version issue. Etch included version do support only select, include, update and delete as prepared statement. Patch provided won`t work. PDO statement can only be used with lenny so or is dropped or an alternative is created for old versions included in etch and sarge. Or everithing is rewritten to use prepared statement only with select, include, update and delete query in old versions.

Patch don't work. When i add this line, i can't Login anymore

Replying to gOOvER:

Patch don't work. When i add this line, i can't Login anymore

Patch was not intended to make it work. It was only to establish if is a version issue. Problem is generated by PDO prepared query dont work if other then INSERT, UPDATE,SELECT or DELETE query is used. With version included in lenny this patch will turn on caching, while in etch will broke functionality (as happend to you). Patch to restablish functionality with etch ill post later after i`ll test. Now i do have a etch box so I can patch and test.

Ah, OK, sorry for missunderstanding :)

This is the patch that supose to make it work. I tested admin operation and client sql operation and works. Test it please. Hope not to break lenny (ill test tonight when ill finish reinstalling my box)

I can't test it at the Moment, because i have too many work.

Symplifyed patch. Please ingnore the rest

I hope my solution will do the same:

if (version_compare(PHP_VERSION, '5.2.5', '<') && 
    preg_match("/(ALTER |CREATE |DROP |GRANT |REVOKE |FLUSH )/i", $sql, $matches) > 0) {
    $this->_db->setAttribute(PDO::MYSQL_ATTR_DIRECT_QUERY, true);
} else {
    $this->_db->setAttribute(PDO::MYSQL_ATTR_DIRECT_QUERY, false);
}

Replying to rats:

I hope my solution will do the same: {{{ if (version_compare(PHP_VERSION, '5.2.5', '<') && preg_match("/(ALTER |CREATE |DROP |GRANT |REVOKE |FLUSH )/i", $sql, $matches) > 0) { $this->_db->setAttribute(PDO::MYSQL_ATTR_DIRECT_QUERY, true); } else { $this->_db->setAttribute(PDO::MYSQL_ATTR_DIRECT_QUERY, false); } }}}

Sorry to reopen but with your solution will be break with lenny (witch has MYSQL_ATTR_DIRECT_QUERY default true and will be forced to 0. This solution supose to work both with etch and lenny.

     if (version_compare(PHP_VERSION, '5.2.5', '<')){
          if(preg_match("/(ALTER |CREATE |DROP |GRANT |REVOKE |FLUSH )/i", $sql, $matches) > 0) {
               $this->_db->setAttribute(PDO::MYSQL_ATTR_DIRECT_QUERY, true);
          } else {
               $this->_db->setAttribute(PDO::MYSQL_ATTR_DIRECT_QUERY, false);
          }
     }

okay :)

Testet with r1264. It didn't work. Now when i try to add a database, i only get a white side.

It`s not the same bug. Change in ispcp/gui/client/sql_database_add.php line 26 from

$tpl->define_dynamic('page', Config::get('CLIENT_TEMPLATE_PATH') . '/add_sql_database.tpl');

in

$tpl->define_dynamic('page', Config::get('CLIENT_TEMPLATE_PATH') . '/sql_database_add.tpl');

thank you. Added in r1268