Development

Wiki Start
Wishlist
Timeline
Roadmap
Browse Source
New Ticket
View Tickets

Ticket #700 (closed enhancement: wontfix)

Opened 1 year ago

Last modified 4 weeks ago

Fit and finish: clean up table formatting

Reported by: pasichnyk Assigned to:
Priority: trivial Milestone: ispCP ω 1.0.0 - RC6
Component: Frontend (GUI) Version: ispCP ω 1.0.0 - RC2
Severity: Hard Keywords: table formatting
Cc:

Description

When displaying lists of items, for example on admin/manage_users.php the table cell padding is way too much.

-I recommend getting rid of this or changing it to a 1px dark grey line. -I also think it would look better with a darker grey border line of 1px or so around the tables outside edge. -Alternating row colors would be great. When you get a bunch of items in a table this makes it much easier on the eyes.

Attachments

styledtable.jpg (60.2 kB) - added by pasichnyk on 09/28/07 09:11:31.
my simple tweaks would make it look like this…
sysinfo.jpg (173.6 kB) - added by pasichnyk on 10/06/07 23:19:07.
screenshot of new table styling
sysinfo-tpl-tablelayoutpatch.patch (6.1 kB) - added by pasichnyk on 10/06/07 23:19:46.
patch to sysinfo.tpl for styling
css-tablelayoutpatch.patch (0.7 kB) - added by pasichnyk on 10/06/07 23:20:29.
patch to ispcp.css for styling of .content and .content2 classes
css-tablelayoutpatch.2.patch (0.7 kB) - added by pasichnyk on 10/07/07 04:11:42.
original patch was in the wrong direction..
sysinfo-tpl-tablelayoutpatch.2.patch (6.1 kB) - added by pasichnyk on 10/07/07 04:12:04.
original patch was in the wrong direction..

Change History

09/22/07 22:40:06 changed by Zottel

a in action screenshot and a patch would be nice ;) The idea behind is good :)

09/28/07 08:15:50 changed by pasichnyk

I'll work on reformatting this to "look better" and provide a patch if i get it to a point i'm happy with.

09/28/07 09:11:31 changed by pasichnyk

  • attachment styledtable.jpg added.

my simple tweaks would make it look like this...

09/28/07 09:16:19 changed by pasichnyk

I attached a image of my quick fix. I think this is a much better look for the table.

1. in the css change td.content2 to have background:#F8F8FF; 2. everywhere for these tables, change all the cellspacing="5" to cellspacing="0px"

10/06/07 23:18:33 changed by pasichnyk

I've created a patch for the ispcp.css as well as for an example page updated to match the new table style I've been working on.

I will attach the two patches as well as a screenshot of what it looks like. I like this layout better, and it wouldn't be too hard to go through all the templates and updated them to match.

10/06/07 23:19:07 changed by pasichnyk

  • attachment sysinfo.jpg added.

screenshot of new table styling

10/06/07 23:19:46 changed by pasichnyk

  • attachment sysinfo-tpl-tablelayoutpatch.patch added.

patch to sysinfo.tpl for styling

10/06/07 23:20:29 changed by pasichnyk

  • attachment css-tablelayoutpatch.patch added.

patch to ispcp.css for styling of .content and .content2 classes

10/06/07 23:23:39 changed by pasichnyk

Just a note, those patches were created against r830. Please let me know if you like this new styling, I'd be happy to create patches for the rest of the .tpl files so they will all match. :)

10/07/07 04:11:42 changed by pasichnyk

  • attachment css-tablelayoutpatch.2.patch added.

original patch was in the wrong direction..

10/07/07 04:12:04 changed by pasichnyk

  • attachment sysinfo-tpl-tablelayoutpatch.2.patch added.

original patch was in the wrong direction..

10/07/07 20:20:29 changed by rats

  • owner set to rats.
  • status changed from new to assigned.
  • milestone changed from ispCP ω 1.0.0 to ispCP ω 1.0.0 - RC3.

we'll discuss, thanks for your help -> Moved to RC3

10/07/07 22:15:00 changed by rats

pasichnyk you're welcome to reformat all styles for tables. Developers have decided, that your idea looks good. Please try to send us the complete patch until 12th of October.

10/09/07 21:36:05 changed by pasichnyk

Rats,

can you please move this to RC4? I have a bunch going on this week and won't be able to tweak all the templates in time. I'd be happy to do this by the end of the month though.

10/09/07 23:11:50 changed by rats

  • milestone changed from ispCP ω 1.0.0 - RC3 to ispCP ω 1.0.0 - RC4.

okay :D moved to RC4

02/17/08 14:47:36 changed by rats

  • severity set to Hard.
  • milestone changed from ispCP ω 1.0.0 - RC4 to Working.

02/25/08 09:06:39 changed by rats

  • milestone changed from Working to ispCP ω 1.0.0.

02/26/08 20:01:51 changed by zothos

  • milestone changed from ispCP ω 1.0.0 to ispCP ω 1.0.0 - RC4.

03/01/08 23:57:32 changed by rats

  • milestone changed from ispCP ω 1.0.0 - RC4 to ispCP ω 1.0.0.

moved; we need a design team to create an css-layer based layout!

03/01/08 23:57:43 changed by rats

  • owner deleted.
  • status changed from assigned to new.

06/15/08 01:20:40 changed by rats

  • milestone changed from ispCP ω 1.0.0 to ispCP ω 1.0.0 - RC5.

06/15/08 13:34:49 changed by zothos

  • milestone changed from ispCP ω 1.0.0 - RC5 to ispCP ω 1.0.0 - RC6.

06/27/08 22:18:03 changed by pasichnyk

I made these changes on a few of the pages, but honestly there is quite a bit of effort required here. To do it cleanly, and make it look right, I have to tweak the table layouts a litte, because they are not optimal right now.

What's the timeframe for getting RC6 out the door? Just wondering if I'll have the time to do all the changes prior to it's release.

The changes look great though. :)

06/30/08 11:52:06 changed by rats

Hey pasichnyk you have as much time as you need. RC6 is shipped if all assigned bugs are closed.

07/21/08 20:32:19 changed by pasichnyk

I really don't have time to do this right now. It requires too much of an overhaul of the templates, and maybe we should just wait and create a new template in the future that has proper layout/styling. (maybe as part of getting this to xhtml/css, and removing the table layouts).

I'd say just close this as won't-fix... Unless someone else wants to go clean up these tables. No reason to hold up RC6 and especially V1.0 for this.

07/24/08 09:51:41 changed by anonymous

simple is working on the templates (omega and modern_blue). so we can close this ticket in my eyes.

07/25/08 10:13:46 changed by rats

  • status changed from new to closed.
  • resolution set to wontfix.

that's my suggestion, too; pasichnyk, please contact simple on further information.

Add/Change #700 (Fit and finish: clean up table formatting)




Action