Development

Wiki Start
Wishlist
Timeline
Roadmap
Browse Source
New Ticket
View Tickets

Ticket #714 (reopened enhancement)

Opened 8 months ago

Last modified 1 month ago

undefined index in pma-style sheet

Reported by: joximu Assigned to: joximu
Priority: feature Milestone: ispCP ω 1.0.0
Component: Frontend (GUI) Version: ispCP ω 1.0.0 - DEV
Severity: Hard Keywords: pma css.php: undefined index
Cc:

Description

Did I miss something?

I have several errors/notices in my php-error-log: 

Undefined index:  BgcolorOne in /var/www/ispcp/gui/tools/pma/phpmyadmin.css.php on line 359

The code looks like this: 

/* left frame content */
body#body_leftFrame {
    background-color: <?php echo $GLOBALS['cfg']['LeftBgColor']; ?>;
}

The following indexes are not defined: 

BgcolorOne
BgcolorTwo
LeftBgColor
LeftPointerColor
RightBgColor
ThBgcolor

would be nice to fix...

(I use pma without beiing logged in into ispcp... - but it also occurs while being logged in with the same browser).

Joximu

Attachments

pma-indices.patch (2.3 kB) - added by joximu on 12/10/2007 06:47:37 PM.
theme_right.css.php (24.2 kB) - added by joximu on 12/14/2007 02:08:31 AM.

Change History

09/24/2007 01:53:23 PM changed by joximu

my ispcp release: 813

priority: would be nice for 1.0...

10/07/2007 08:15:57 PM changed by rats

is the error still there?

11/29/2007 11:13:55 PM changed by rats

  • milestone changed from ispCP ω 1.0.0 to ispCP ω 1.0.0 - RC4.

12/10/2007 11:49:27 AM changed by joximu

  • status changed from new to closed.
  • resolution set to fixed.

Hi

I think this can be solved with this:

pma/themes/omega/info.inc.php: [code] <?php /* Theme information */ $theme_name = 'omega'; #$theme_version = 2; #$theme_generation = 2; $theme_full_version = '2.9'; ?> /code

the two commented $theme_... variables should be replaced by the new $theme_full_version (at least the two default themes do it like this). Background: There are several lines which are only executed for old themes... so the version numbering has to be adopted to the new pma version... Since we don't have older (than 2.9) pma versions around should be no problem...

Then the index errors have dissappeared.

I'll put this in my trunk, will be fixed in my next commit.

12/10/2007 11:50:17 AM changed by joximu

Sory - the code: 

<?php
/* Theme information */
$theme_name = 'omega';
$theme_full_version = '2.9';
#$theme_version = 2;
#$theme_generation = 2;
?>

12/10/2007 12:06:12 PM changed by joximu

  • status changed from closed to reopened.
  • resolution deleted.

Hm... now the login-screen is on the left :-(

I'll solve this...

12/10/2007 12:06:21 PM changed by joximu

  • owner set to joximu.
  • status changed from reopened to new.

12/10/2007 12:25:28 PM changed by joximu

  • status changed from new to assigned.

Could someone test this patch also?

Loginform is centered again - but there are maybe other side effects???

Thanx

12/10/2007 01:20:36 PM changed by rbtux

Well the login form looks like before... (I mean it looked nice before and looks nice now...)

What again should the patch fix??

I sent you a pm with the link to the pma login screen of my installation. Check it yourself...

12/10/2007 01:22:44 PM changed by rbtux

at second look:

In german version you cannot see the whole "Server auswählen:" text...

12/10/2007 01:28:45 PM changed by joximu

The "problems" were theese - only visible in a php-error-log with all errors: 

[10-Dec-2007 11:32:58] PHP Notice:  Undefined index:  LeftBgColor in /var/www/ispcp/gui/tools/pma/phpmyadmin.css.php on line 121
[10-Dec-2007 11:32:58] PHP Notice:  Undefined index:  LeftBgColor in /var/www/ispcp/gui/tools/pma/phpmyadmin.css.php on line 149
[10-Dec-2007 11:32:58] PHP Notice:  Undefined index:  LeftPointerColor in /var/www/ispcp/gui/tools/pma/phpmyadmin.css.php on line 160
[10-Dec-2007 11:32:58] PHP Notice:  Undefined index:  ThBgcolor in /var/www/ispcp/gui/tools/pma/phpmyadmin.css.php on line 269
[10-Dec-2007 11:32:58] PHP Notice:  Undefined index:  BgcolorOne in /var/www/ispcp/gui/tools/pma/phpmyadmin.css.php on line 283
[10-Dec-2007 11:32:58] PHP Notice:  Undefined index:  RightBgColor in /var/www/ispcp/gui/tools/pma/phpmyadmin.css.php on line 300
[10-Dec-2007 11:32:58] PHP Notice:  Undefined index:  BgcolorOne in /var/www/ispcp/gui/tools/pma/phpmyadmin.css.php on line 366
[10-Dec-2007 11:32:58] PHP Notice:  Undefined index:  BgcolorTwo in /var/www/ispcp/gui/tools/pma/phpmyadmin.css.php on line 367
[10-Dec-2007 11:32:58] PHP Notice:  Undefined index:  BgcolorTwo in /var/www/ispcp/gui/tools/pma/phpmyadmin.css.php on line 381
[10-Dec-2007 11:32:58] PHP Notice:  Undefined index:  BgcolorOne in /var/www/ispcp/gui/tools/pma/phpmyadmin.css.php on line 406
[10-Dec-2007 11:32:58] PHP Notice:  Undefined index:  BgcolorTwo in /var/www/ispcp/gui/tools/pma/phpmyadmin.css.php on line 412
[10-Dec-2007 11:32:58] PHP Notice:  Undefined index:  LeftBgColor in /var/www/ispcp/gui/tools/pma/phpmyadmin.css.php on line 647
[10-Dec-2007 11:32:58] PHP Notice:  Undefined index:  LeftBgColor in /var/www/ispcp/gui/tools/pma/phpmyadmin.css.php on line 652
[10-Dec-2007 11:32:58] PHP Notice:  Undefined index:  BgcolorOne in /var/www/ispcp/gui/tools/pma/phpmyadmin.css.php on line 721
[10-Dec-2007 11:32:58] PHP Notice:  Undefined index:  BgcolorTwo in /var/www/ispcp/gui/tools/pma/phpmyadmin.css.php on line 722

I like to test my apps with error_reporting = E_ALL and then no entry should be listed! Sort of a personal perfection :-)

Well, therefore I don't see anything on your pma, besides it looks like it should... Just do some work with pma and ifanything is diferent than in a non patched version let me know...

Just noticed too: the first page is not in two columns... I'll improove my patch...

/J

12/10/2007 01:45:04 PM changed by joximu

new version: now the first screen after login looks "normal" again...

also the new theme_right.css.php for those who already tried the first patch...

12/10/2007 06:47:37 PM changed by joximu

  • attachment pma-indices.patch added.

12/14/2007 12:45:03 AM changed by rats

  • milestone changed from ispCP ω 1.0.0 - RC4 to ispCP ω 1.0.0 - RC3.

12/14/2007 02:08:31 AM changed by joximu

  • attachment theme_right.css.php added.

12/14/2007 02:13:02 AM changed by joximu

I just added the mostly corrected theme_right.css.php which should be replaced if the changes in info.inc.php are done... Hi RatS - why did you commit only a part????

There are still some small things to fix - I think this would be a nice task for some CSS freinds... - I'd take the original theme and the replace the colours and pictures and leave the remaining part as is...

/J

PS: I also can deliver a patch for the file...

12/14/2007 09:33:47 AM changed by rats

delirium ... :D I'll check the rest this weekend.

12/14/2007 09:43:48 AM changed by joximu

Hi rats - please work on ticket 55 - I'll keep an eye on this...

12/16/2007 12:01:00 AM changed by rats

  • status changed from assigned to closed.
  • resolution set to fixed.

r947

01/07/2008 11:42:00 PM changed by joximu

  • priority changed from major to feature.
  • status changed from closed to reopened.
  • resolution deleted.
  • milestone changed from ispCP ω 1.0.0 - RC3 to ispCP ω 1.1.0.

I reopened this, because I reverted the changes which should have fixed this bug but did not.

This Ticket requires more than a few changes in the theme.

The php errors are not that heavy - a theme that's not ok is worse.

02/17/2008 02:47:56 PM changed by rats

  • severity set to Hard.
  • milestone changed from ispCP ω 1.1.0 to Working.

03/14/2008 04:33:46 PM changed by rats

  • milestone changed from Working to ispCP ω 1.0.0 - RC4.

03/14/2008 04:33:52 PM changed by rats

  • milestone changed from ispCP ω 1.0.0 - RC4 to ispCP ω 1.0.0.

04/10/2008 02:55:16 AM changed by anonymous

电子地磅解码器,吨位遥控器/本吨位遥控器引进日本先进技术研制而成，完全采用数字式集成电路技术，采用万能解码数据处理线路，适用于10----150吨以下吨位，无须对地磅作任何改动 具有防拦截，防扫描等优点，解码器安装于车上或离地磅8米以内，在电子称旁40米或60米以内，能控制电子称的数码数据，最小值20公斤，规格10 /15/20，此产品主要产生电子磁场干扰和控制，从而使吨位变大或变小，性能稳定可靠，体积小，遥控主机 解码处理器 如烟盒大小，遥控器配两种型号，隐蔽性强，附件含使用光盘一套，

Add/Change #714 (undefined index in pma-style sheet)