Development

Wiki Start
Wishlist
Timeline
Roadmap
Browse Source
New Ticket
View Tickets

Ticket #747 (closed enhancement: fixed)

Opened 1 year ago

Last modified 4 weeks ago

use of unused field mail_addr in table mail_users

Reported by: Joximu Assigned to: joximu
Priority: blocker Milestone: ispCP ω 1.0.0 - RC4
Component: Backend (Engine) Version: ispCP ω 1.0.0 - DEV
Severity: Hard Keywords: use of field mail_addr
Cc:

Description (Last modified by joximu)

While writing the "howto password change in webmail" I saw that there is an empty field in the database "ispcp.mail_users.mail_addr" which would - if used - save alot of database queries when having the mail_addr and wanting to find out what mail_user_id it is. http://www.isp-control.net/ispcp/wiki/howto_webmailpass

In this Threat we learn why there is a field mail_addr - and why it isn't used... http://www.isp-control.net/forum/squirrelmail-change-password-t-202.html

Here we have another patch - also regarding idna-mail-domains (I didn't cover this in my solution): http://www.isp-control.net/forum/squirrelmail-change-password-t-202.html#pid1405

I think this field should be set - even if no one uses it. It'd save time/work/db-quesries for all extensions/enhancements. And I think this change does not interfere with anything else (eg. there is not code which depends on this field being empty???)

Attachments

mail_addr-diff-add_mail_acc.txt (2.2 kB) - added by joximu on 10/05/07 15:20:48.
my patch for client/add_mail_acc.php, r823 or sth. around this…

Change History

10/05/07 15:20:48 changed by joximu

  • attachment mail_addr-diff-add_mail_acc.txt added.

my patch for client/add_mail_acc.php, r823 or sth. around this...

12/10/07 20:28:03 changed by joximu

  • description changed.
  • summary changed from use of unised field mail_addr in tabel mail_users to use of unused field mail_addr in table mail_users.

02/17/08 14:48:15 changed by rats

  • severity set to Hard.
  • milestone changed from ispCP ω 1.0.0 - RC4 to Working.

02/17/08 23:29:01 changed by rats

  • priority changed from major to blocker.
  • milestone changed from Working to ispCP ω 1.0.0 - RC4.

02/19/08 00:32:33 changed by joximu

  • owner set to joximu.

02/25/08 02:40:24 changed by joximu

  • status changed from new to closed.
  • resolution set to fixed.

fixed in r1020

08/13/08 16:36:23 changed by anonymous

http://www.salewroughtiron.cn installing metal stair rails Interior stair handrail installing metal stair rails Interior stair handrail exterior baluster Glass wood stainless wrought CONTEMPORARY designs stairways aluminum modern log banister DECK outdoor price posts vinyl curved rails http://www.china-made-door.com.cn door gate http://www.beijing-door.cn wrought CONTEMPORARY designs stairways installing metal stair rails Interior stair handrail exterior baluster Glass wood stainless wrought CONTEMPORARY designs stairways aluminum modern log banister DECK outdoor price posts vinyl curved rails http://www.hebei-railings.cn aluminum modern log banister DECK outdoor price installing metal stair rails Interior stair handrail exterior baluster Glass wood stainless wrought CONTEMPORARY designs stairways aluminum modern log banister DECK outdoor price posts vinyl curved rails posts vinyl curved rails

Add/Change #747 (use of unused field mail_addr in table mail_users)




Action